rok commented on a change in pull request #9758:
URL: https://github.com/apache/arrow/pull/9758#discussion_r628652294
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc
##########
@@ -659,18 +659,17 @@ TEST(GroupBy, ConcreteCaseWithValidateGroupBy) {
[null, "gama"]
])");
- CountOptions count_non_null{CountOptions::COUNT_NON_NULL},
- count_null{CountOptions::COUNT_NULL};
-
- MinMaxOptions emit_null{MinMaxOptions::EMIT_NULL};
+ ScalarAggregateOptions keepna{false, 1};
+ ScalarAggregateOptions skipna{true, 1};
+ ScalarAggregateOptions other{true, 1};
using internal::Aggregate;
for (auto agg : {
- Aggregate{"hash_sum", nullptr},
Review comment:
Reintroduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
