wgtmac commented on code in PR #49914:
URL: https://github.com/apache/arrow/pull/49914#discussion_r3207344358
##########
cpp/src/parquet/encoding_test.cc:
##########
@@ -462,8 +462,33 @@ TYPED_TEST(TestDictionaryEncoding, BasicRoundTrip) {
ASSERT_NO_FATAL_FAILURE(this->Execute(2500, 2));
}
-TEST(TestDictionaryEncoding, CannotDictDecodeBoolean) {
- ASSERT_THROW(MakeDictDecoder<BooleanType>(nullptr), ParquetException);
+// Round trip a dictionary encoded boolean column. The dictionary holds two
Review Comment:
This does not look like a round trip test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
