mapleFU commented on code in PR #49914:
URL: https://github.com/apache/arrow/pull/49914#discussion_r3207710483
##########
cpp/src/parquet/decoder.cc:
##########
@@ -1038,7 +1038,13 @@ void DictDecoderImpl<Type>::SetDict(TypedDecoder<Type>*
dictionary) {
template <>
void DictDecoderImpl<BooleanType>::SetDict(TypedDecoder<BooleanType>*
dictionary) {
- ParquetException::NYI("Dictionary encoding is not implemented for boolean
values");
+ dictionary_length_ = static_cast<int32_t>(dictionary->values_left());
+ PARQUET_THROW_NOT_OK(dictionary_->Resize(
+ static_cast<int64_t>(dictionary_length_) * sizeof(bool), false));
+ if (dictionary->Decode(dictionary_->mutable_data_as<bool>(),
dictionary_length_) !=
+ dictionary_length_) {
+ throw ParquetException("Could not decode boolean dictionary values");
Review Comment:
I don't think it's a proper error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
