pchintar commented on PR #9836: URL: https://github.com/apache/arrow-rs/pull/9836#issuecomment-4408532787
> Thansk for this @pchintar -- > > I am a little worried that this introduces a second almost-but-not-quite-tthe-same path for writing batches to IPC. I think we could do better if we did a more holistic rearranging of the code -- let me know what you think @alamb The dictionary path remains unchanged in this PR and should not require any additional copies, alignment requirements or regressions for that specific case. I also looked into threading the writer further into `IpcDataGenerator`, but that would require restructuring the recursive dictionary emission path as well, so I kept this change focused on the shared reusable encoding path for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
