pchintar commented on code in PR #9836:
URL: https://github.com/apache/arrow-rs/pull/9836#discussion_r3210219705
##########
arrow-ipc/src/writer.rs:
##########
@@ -1550,6 +1596,163 @@ impl<W: Write> RecordBatchWriter for StreamWriter<W> {
}
}
+fn has_dictionary_batch(batch: &RecordBatch) -> bool {
+ batch
+ .schema()
+ .fields()
+ .iter()
+ .any(|field| has_dictionary_type(field.data_type()))
+}
+
+fn has_dictionary_type(data_type: &DataType) -> bool {
+ match data_type {
+ DataType::Dictionary(_, _) => true,
+ DataType::Struct(fields) => fields.iter().any(|f|
has_dictionary_type(f.data_type())),
+ DataType::List(field)
+ | DataType::LargeList(field)
+ | DataType::ListView(field)
+ | DataType::LargeListView(field)
+ | DataType::FixedSizeList(field, _) =>
has_dictionary_type(field.data_type()),
+ DataType::Map(field, _) => has_dictionary_type(field.data_type()),
+ DataType::RunEndEncoded(_, field) =>
has_dictionary_type(field.data_type()),
+ DataType::Union(fields, _) => fields
+ .iter()
+ .any(|(_, f)| has_dictionary_type(f.data_type())),
+ _ => false,
+ }
+}
+
+fn write_record_batch_fast<W: Write>(
+ writer: &mut W,
+ batch: &RecordBatch,
+ write_options: &IpcWriteOptions,
+ compression_context: &mut CompressionContext,
+ scratch: &mut IpcWriterScratch,
+) -> Result<(usize, usize), ArrowError> {
+ scratch.fbb.reset();
+ scratch.nodes.clear();
+ scratch.buffers.clear();
+ scratch.arrow_data.clear();
+ scratch.variadic_buffer_counts.clear();
+
+ let batch_compression_type = write_options.batch_compression_type;
Review Comment:
Now with shared `encode_record_batch_into(...)` and the removal of
`write_record_batch_fast(...)` there is:
* ONE serialization implementation
* reused by both paths & no duplicated logic
So this is resolved now I guess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
