zeroshade commented on issue #804: URL: https://github.com/apache/arrow-go/issues/804#issuecomment-4410140898
Mostly that it does have a slight effect on performance potentially, though unless you're converting very large json blobs you probably wouldn't notice. Essentially using `json.Number` will keep it as a string and parse on the fly rather than creating the float64 during the json.Unmarshal in the first place. So it would cause a bunch of extra allocations/string parsing if you don't need it. I suppose we could deprecate the `WithUseNumber` option, make it a no-op, add a new `WithNoUseNumber` option and make using the json.Number the default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
