zeroshade commented on code in PR #4050: URL: https://github.com/apache/arrow-adbc/pull/4050#discussion_r3236614310
########## c/include/arrow-adbc/adbc.h: ########## @@ -1977,26 +1977,41 @@ AdbcStatusCode AdbcConnectionGetInfo(struct AdbcConnection* connection, /// /// The result is an Arrow dataset with the following schema: /// -/// | Field Name | Field Type | -/// |--------------------------|-------------------------| -/// | catalog_name | utf8 | -/// | catalog_db_schemas | list<DB_SCHEMA_SCHEMA> | +/// | Field Name | Field Type | Comments | +/// |--------------------------|-------------------------|----------| +/// | catalog_name | utf8 | | +/// | catalog_db_schemas | list<DB_SCHEMA_SCHEMA> | | +/// | remarks | utf8 | (1) | +/// +/// 1. [Since version 1.2.0] A description of the catalog. This field is +/// optional. /// /// DB_SCHEMA_SCHEMA is a Struct with fields: /// -/// | Field Name | Field Type | -/// |--------------------------|-------------------------| -/// | db_schema_name | utf8 | -/// | db_schema_tables | list<TABLE_SCHEMA> | +/// | Field Name | Field Type | Comments | +/// |--------------------------|-------------------------|----------| +/// | db_schema_name | utf8 | | +/// | db_schema_tables | list<TABLE_SCHEMA> | | +/// | remarks | utf8 | (1) | +/// +/// 1. [Since version 1.2.0] A description of the schema. This field is +/// optional. /// /// TABLE_SCHEMA is a Struct with fields: /// -/// | Field Name | Field Type | -/// |--------------------------|-------------------------| -/// | table_name | utf8 not null | -/// | table_type | utf8 not null | -/// | table_columns | list<COLUMN_SCHEMA> | -/// | table_constraints | list<CONSTRAINT_SCHEMA> | +/// | Field Name | Field Type | Comments | +/// |--------------------------|-------------------------|----------| +/// | table_name | utf8 not null | | +/// | table_type | utf8 not null | | +/// | table_columns | list<COLUMN_SCHEMA> | | +/// | table_constraints | list<CONSTRAINT_SCHEMA> | | +/// | table_definition | utf8 | (1) | +/// | remarks | utf8 | (2) | +/// Review Comment: I agree with @paleolimbot that I very much don't love the idea of shoving an IPC schema into this... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
