Copilot commented on code in PR #49851: URL: https://github.com/apache/arrow/pull/49851#discussion_r3270746663
########## cpp/src/arrow/flight/sql/odbc/connection-options.md: ########## @@ -0,0 +1,64 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Connection Properties on Apache Arrow Flight SQL ODBC Driver + +## Setting ODBC Connection Properties + +ODBC connection parameters can be set in a connection string or defined in a DSN. On macOS and Linux, DSNs are typically defined in your system's `odbc.ini`. On Windows they are typically configured with the ODBC Data Source Administrator. + +The following sample connection string and sample DSN are two equivalent ways to connect to Arrow. + Review Comment: The text claims the sample connection string and sample DSN are equivalent, but the driver does not currently load all listed options from DSNs. `Configuration::LoadDsn` only reads host/port/token/uid/pwd/trustedCerts and the TLS booleans; keys like `user`/`password`, `useWideChar`, `stringColumnLength`, and `chunkBufferCapacity` won’t be picked up when set in `odbc.ini` (they’re treated as known keys and filtered out). Please either (a) update this document to clearly distinguish which properties are supported via DSN vs connection string, or (b) extend DSN loading to read the additional known keys. ########## cpp/src/arrow/flight/sql/odbc/README.md: ########## @@ -129,3 +148,4 @@ After ODBC has been registered, you can run the ODBC tests. It is recommended to - Conversion from timestamp data type with specified time zone value to strings is not supported at the moment. This doesn't impact driver's usage of retrieving timestamp data from Power BI on Windows, and Excel on macOS and Windows. See GH-47504 for more context. - Conversion from strings to big int data type has a limit range of -9007199254740992 to 9007199254740992. +- On Linux, `isql` commands `tables` and `columns` don't work due to GH-49702. Users are not blocked from fetching data tables. Review Comment: Minor wording: “Users are not blocked from fetching data tables” reads awkwardly/unclear (it’s not obvious whether this means fetching table *metadata* or querying table *data*). Consider rephrasing to something like users can still query data despite `isql` metadata commands failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
