ritchie46 commented on pull request #269: URL: https://github.com/apache/arrow-rs/pull/269#issuecomment-836581376
> I am sorry if this exercise was a waste of time, but I certainly learned something reading the comment threads. No, worries. It was on the shelf. > I think that an issue with dyn MutableBuffer is that the compiler is unable to inline function calls (because they are now pointed to from a vtable). I have not measured the performance impact, though, so I can't say for sure. Yes, there will be less inlining in the code that goes through the trait object indeed. I don't know how much of the inner API has to go though `Vec<MutableBuffer>` and thus needs `Vec<dyn MutableBuffer>`. I can image that a lot of `primitive` builders could use the typed version `MutableBuffer<T::Native> where T is PrimitiveType`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
