Copilot commented on code in PR #49986:
URL: https://github.com/apache/arrow/pull/49986#discussion_r3299974319
##########
cpp/src/gandiva/function_registry.h:
##########
@@ -85,6 +85,10 @@ class GANDIVA_EXPORT FunctionRegistry {
private:
std::vector<NativeFunction> pc_registry_;
SignatureMap pc_registry_map_;
+ // Tracks name+param-types (return type ignored) to detect call-shape
collisions
+ // where the same `name(args)` could resolve to two functions with different
+ // return types.
+ std::unordered_map<std::string, const FunctionSignature*> call_shape_map_;
std::vector<std::shared_ptr<arrow::Buffer>> bitcode_memory_buffers_;
Review Comment:
`FunctionRegistry` now has a `std::unordered_map` member (`call_shape_map_`)
but this header doesn’t include `<unordered_map>` directly; it currently
compiles only because `<unordered_map>` is pulled in transitively via
`function_registry_common.h`. Please add an explicit `#include <unordered_map>`
in this header to keep it self-contained and avoid fragile transitive-include
dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
