hengfeiyang commented on code in PR #734:
URL:
https://github.com/apache/arrow-rs-object-store/pull/734#discussion_r3318684627
##########
src/aws/mod.rs:
##########
@@ -264,6 +264,25 @@ impl ObjectStore for AmazonS3 {
locations: BoxStream<'static, Result<Path>>,
) -> BoxStream<'static, Result<Path>> {
let client = Arc::clone(&self.client);
+
+ // Some S3-compatible providers do not implement
+ // the bulk `DeleteObjects` API (`POST /?delete`). When bulk delete is
+ // disabled, fall back to parallel single-object `DELETE /key`
requests,
+ // which are part of the core S3 API supported by every provider.
+ if client.config.disable_bulk_delete {
+ return locations
+ .map(move |location| {
+ let client = Arc::clone(&client);
+ async move {
+ let location = location?;
+ client.delete_request(&location).await?;
+ Ok(location)
+ }
+ })
+ .buffered(20)
Review Comment:
Yes. it is from bellow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
