hengfeiyang commented on PR #734:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/734#issuecomment-4572839056

   @alamb i added 4 new unit tests, the key point is different option will 
generate different result:
   - with_virtual_hosted_style_request
   - with_disable_bulk_delete
   
   ## Unit tests
   
     | # | Test name | virtual_hosted | disable_bulk_delete | Expected request |
     |---|-----------|----------------|---------------------|------------------|
     | 1 | `test_delete_default` | `false` | `false` | `POST 
/test-bucket?delete` |
     | 2 | `test_delete_default_with_disable_bulk` | `false` | `true` | `DELETE 
/test-bucket/foo`, `DELETE /test-bucket/bar` (no query) |
     | 3 | `test_delete_virtual_hosted` | `true` | `false` | `POST /?delete` |
     | 4 | `test_delete_virtual_hosted_with_disable_bulk` | `true` | `true` | 
`DELETE /foo`, `DELETE /bar` (no query) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to