Copilot commented on code in PR #50085:
URL: https://github.com/apache/arrow/pull/50085#discussion_r3352160668
##########
.github/workflows/cpp_extra.yml:
##########
@@ -554,10 +554,19 @@ jobs:
ARROW_FLIGHT_SQL_ODBC: ON
ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON
ARROW_HOME: /usr
+ # GH-49465: work around the gRPC/Abseil exit hang on Windows
+ # https://github.com/grpc/grpc/issues/39321
+ # https://github.com/abseil/abseil-cpp/issues/1877
+ # Build Arrow with GPR_DISABLE_ABSEIL_SYNC so grpcpp's Mutex ABI
+ # matches the gRPC rebuilt by the overlay triplet. Remove once fixed
upstream.
+ ARROW_CXXFLAGS: -DGPR_DISABLE_ABSEIL_SYNC
Review Comment:
On MSVC builds, `ARROW_CXXFLAGS` is appended verbatim to
`CMAKE_CXX_FLAGS`/`CMAKE_C_FLAGS` (see `cpp/CMakeLists.txt`), so using
GCC-style `-D...` risks being ignored by `cl.exe`. Use the MSVC-style `/D...`
form here to ensure Arrow is actually built with `GPR_DISABLE_ABSEIL_SYNC` and
matches the vcpkg-built gRPC ABI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
