tadeja commented on code in PR #50085:
URL: https://github.com/apache/arrow/pull/50085#discussion_r3358094579
##########
.github/workflows/cpp_extra.yml:
##########
@@ -554,10 +554,19 @@ jobs:
ARROW_FLIGHT_SQL_ODBC: ON
ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON
ARROW_HOME: /usr
+ # GH-49465: work around the gRPC/Abseil exit hang on Windows
+ # https://github.com/grpc/grpc/issues/39321
+ # https://github.com/abseil/abseil-cpp/issues/1877
+ # Build Arrow with GPR_DISABLE_ABSEIL_SYNC so grpcpp's Mutex ABI
+ # matches the gRPC rebuilt by the overlay triplet. Remove once fixed
upstream.
+ ARROW_CXXFLAGS: -DGPR_DISABLE_ABSEIL_SYNC
CMAKE_GENERATOR: Ninja
CMAKE_INSTALL_PREFIX: /usr
VCPKG_BINARY_SOURCES: 'clear;nugettimeout,600;nuget,GitHub,readwrite'
- VCPKG_DEFAULT_TRIPLET: x64-windows
+ # GH-49465: custom triplet that rebuilds gRPC with
GPR_DISABLE_ABSEIL_SYNC
+ # (native sync instead of absl::Mutex). See
ci/vcpkg/overlay-triplets-no-absl-sync.
+ VCPKG_DEFAULT_TRIPLET: x64-windows-no-absl-sync
Review Comment:
Done, renamed to `amd64-windows-no-absl-sync-release`
##########
.github/workflows/cpp_extra.yml:
##########
@@ -554,10 +554,19 @@ jobs:
ARROW_FLIGHT_SQL_ODBC: ON
ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON
ARROW_HOME: /usr
+ # GH-49465: work around the gRPC/Abseil exit hang on Windows
+ # https://github.com/grpc/grpc/issues/39321
+ # https://github.com/abseil/abseil-cpp/issues/1877
+ # Build Arrow with GPR_DISABLE_ABSEIL_SYNC so grpcpp's Mutex ABI
+ # matches the gRPC rebuilt by the overlay triplet. Remove once fixed
upstream.
+ ARROW_CXXFLAGS: -DGPR_DISABLE_ABSEIL_SYNC
CMAKE_GENERATOR: Ninja
CMAKE_INSTALL_PREFIX: /usr
VCPKG_BINARY_SOURCES: 'clear;nugettimeout,600;nuget,GitHub,readwrite'
- VCPKG_DEFAULT_TRIPLET: x64-windows
+ # GH-49465: custom triplet that rebuilds gRPC with
GPR_DISABLE_ABSEIL_SYNC
+ # (native sync instead of absl::Mutex). See
ci/vcpkg/overlay-triplets-no-absl-sync.
+ VCPKG_DEFAULT_TRIPLET: x64-windows-no-absl-sync
+ VCPKG_OVERLAY_TRIPLETS: ${{ github.workspace
}}/ci/vcpkg/overlay-triplets-no-absl-sync
Review Comment:
Done, moved to `ci/vcpkg/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
