dmatth1 commented on code in PR #50030:
URL: https://github.com/apache/arrow/pull/50030#discussion_r3358816300
##########
cpp/src/parquet/bloom_filter_test.cc:
##########
@@ -434,5 +445,86 @@ TYPED_TEST(TestBatchBloomFilter, Basic) {
AssertBufferEqual(*buffer, *batch_insert_buffer);
}
+// Guards against silent drift between the baseline and AVX2 probe bodies --
+// DynamicDispatch only runs one of them per host.
+#if defined(ARROW_HAVE_RUNTIME_AVX2)
+namespace {
+
+// 8-lane block matches BlockSplitBloomFilter's hard-coded shape; declared
+// locally so the test doesn't depend on the class's private constants.
+constexpr int kProbeBlockLanes = 8;
+
+// Test-only SALT (matches the Parquet SBBF spec values used in
+// bloom_filter.h). Kernel-vs-kernel agreement holds for any SALT, so this
+// duplication is a contained test-side convenience, not a spec mirror.
+alignas(32) constexpr uint32_t kProbeTestSalt[kProbeBlockLanes] = {
Review Comment:
Yes! Removing all 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
