HuaHuaY commented on code in PR #50030:
URL: https://github.com/apache/arrow/pull/50030#discussion_r3382016046
##########
cpp/src/parquet/bloom_filter_test.cc:
##########
@@ -434,5 +443,85 @@ TYPED_TEST(TestBatchBloomFilter, Basic) {
AssertBufferEqual(*buffer, *batch_insert_buffer);
}
+// Guards against silent drift between the baseline and AVX2 probe bodies --
+// DynamicDispatch only runs one of them per host.
+#if defined(ARROW_HAVE_RUNTIME_AVX2)
+namespace {
+
+// Mirror of BlockSplitBloomFilter::kBitsSetPerBlock (private to the class).
+constexpr int kBitsSetPerBlock = 8;
Review Comment:
We already have a definition in `cpp/src/parquet/bloom_filter.h`. We can use
it.
##########
cpp/src/parquet/bloom_filter_block_impl_internal.h:
##########
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#pragma once
+
+#include <cstdint>
+
+namespace parquet::internal {
+
+inline bool FindHashBlockImpl(const uint32_t* block, const uint32_t* salt,
uint32_t key) {
+ constexpr int kBitsSetPerBlock = 8;
Review Comment:
Why define a new `kBitsSetPerBlock` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
