Jimexist commented on a change in pull request #307:
URL: https://github.com/apache/arrow-datafusion/pull/307#discussion_r630249637
##########
File path: datafusion/src/physical_plan/functions.rs
##########
@@ -1373,20 +1374,28 @@ impl PhysicalExpr for ScalarFunctionExpr {
}
fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> {
Review comment:
@alamb tried a different approach using `TryFrom` trait, so it's more
obvious. the call site convention I'll try to code in #303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
