Jimexist commented on a change in pull request #307:
URL: https://github.com/apache/arrow-datafusion/pull/307#discussion_r630911914
##########
File path: datafusion/src/physical_plan/functions.rs
##########
@@ -1373,20 +1374,28 @@ impl PhysicalExpr for ScalarFunctionExpr {
}
fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> {
Review comment:
> Docs in the next PR is fine. I think @jorgecarleitao had an alternate
suggestion in [#303
(comment)](https://github.com/apache/arrow-datafusion/pull/303#discussion_r630285020)
see https://github.com/apache/arrow-datafusion/pull/328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
