pitrou commented on code in PR #41128:
URL: https://github.com/apache/arrow/pull/41128#discussion_r3412497204
##########
cpp/src/arrow/memory_pool_internal.h:
##########
@@ -49,8 +46,21 @@ class JemallocAllocator {
#endif // defined(ARROW_JEMALLOC)
-} // namespace internal
+} // namespace arrow::memory_pool::internal
+
+#ifdef ARROW_MIMALLOC
-} // namespace memory_pool
+extern "C" {
+// GH-50083: expose public symbols with well-known names for memory profilers
+// to be able to intercept our mimalloc calls and better make sense of Arrow's
+// memory profile.
+// These symbols need to be interposable (using e.g. `LD_PRELOAD`), which is
+// ensured using a custom compilation flag in CMakeLists.txt.
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
