kevinjqliu opened a new pull request, #757:
URL: https://github.com/apache/arrow-rs-object-store/pull/757
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The close-file error tests tried to force an error by closing a temp file,
rebuilding a `File` from the now-invalid fd/handle, and closing it again. In
parallel test runs, that fd/handle value can be reused by another test, causing
the close test to unexpectedly succeed or close another test's resource.
This makes CI flaky and has affected two PRs recently:
- apache/arrow-rs-object-store#742:
https://github.com/apache/arrow-rs-object-store/actions/runs/27587416868/job/81712651684?pr=742
- apache/arrow-rs-object-store#710:
https://github.com/apache/arrow-rs-object-store/actions/runs/25238554718/job/74009722459?pr=710
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This adds small Unix and Windows helpers for closing raw fd/handle values,
and keeps `close_file(File)` delegating to those helpers.
The close-file error tests now assert the expected invalid fd/handle errors
directly, instead of reconstructing a `File` from a closed resource.
# Are there any user-facing changes?
No. This only changes internal test coverage for local filesystem
close-error handling.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
