andishgar commented on issue #50249: URL: https://github.com/apache/arrow/issues/50249#issuecomment-4841468383
@pitrou, to wrap up my point: the current `BaseBinaryBuilder` API does not provide a way to determine whether the current value is null while iterating. I used the `compute::unique` implementation for `BinaryView` as an example: because `BaseBinaryBuilder` has no API to check whether a value is null, it ends up using incorrect logic for null values. Given this, would it make sense to add an `IsNull(index)` API to `BaseBinaryBuilder`? Our discussion is not about the `unique` kernel itself—`unique` is just an example that demonstrates why the current `BaseBinaryBuilder` API is insufficient for iteration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
