fallintoplace opened a new pull request, #872: URL: https://github.com/apache/arrow-go/pull/872
### What changed array.Hash now writes the array data type fingerprint, length, offset, every buffer with boundaries and nil markers, child data in order, and dictionary data when present. ### Why The old implementation wrote length twice and only considered the null bitmap plus child data. That meant arrays with different value buffers, types, offsets, or dictionaries could produce the same hash. ### Validation - go test ./arrow/array -run TestHashIncludesDataMetadataAndBuffers -count=1 - go test ./arrow/array -count=1 - PARQUET_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/parquet-testing/data ARROW_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/arrow-testing/data go test ./... -count=1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
