returnString edited a comment on pull request #288: URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-840494765
Yeah on the basis that `now` is quite a common/useful function and this PR plus @alamb's closure change resolves this in a neat way, my suggestion would be: - try to merge this (excellent!) work with #335 on top to address the concerns around high-impact signature changes - plan future work to better support different "classes" of function at both the logical layer and the physical (as @jorgecarleitao explained above) Especially at the logical level, I think there are _more_ potential benefits here than just supporting stateful functions outright, like enabling better plan optimisation, and we could probably do with some upfront design work on that first 😄 Edit: also, if/when we land some work for stateful functions, there's nothing that stops us migrating this across later! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
