xborder commented on code in PR #4488:
URL: https://github.com/apache/arrow-adbc/pull/4488#discussion_r3569833348
##########
docs/source/driver/flight_sql.rst:
##########
@@ -81,6 +81,45 @@ the :c:struct:`AdbcDatabase`.
.. recipe:: ../../../go/adbc/driver/flightsql/example_usage_test.go
+URI Format
+----------
+
+The "uri" option accepts URIs using the ``flightsql://`` scheme. The
+transport is selected with the ``transport`` query parameter, which is
+matched case-insensitively:
+
+``flightsql://<host>:<port>``
+ Connect over gRPC with TLS (secure). This is the default when no
+ ``transport`` query parameter is given.
+
+``flightsql://<host>:<port>?transport=tls``
Review Comment:
I wouldn't pass this a parameter in the URI tho since it seems that the
usual way of configuring behavior is through options. Probably I would create a
an option `useEncryption` (or similar) for this.
```
- flightsql://host:port
TLS enabled (same as grpc+tls)
- flightsql://host:port + option.flightsql.useEncryption = false
TLS disabled, plaintext TCP (same as grpc+tcp)
```
From what I've seen, the JDBC driver doesn't support `grpc+unix`. You can
still use it with a FlightSQL client but not through the driver. I would
probably follow a similar pattern by allowing users to specify
`grpc+(tcp|tls|unix)` but promoting `flightsql://`
Adding `?transport=unix|tcp|tls` doesn't answer this
[requirement](https://github.com/apache/arrow-adbc/issues/4453) since it is not
part o the URI scheme:
> And most or all of the driver managers now support searching for drivers
based on the URI scheme when the driver is not otherwise specified.
As another alternative, we can use the same approach as
[JDBC](https://docs.oracle.com/javase//1.5.0/docs/guide/jdbc/getstart/connection.html):
> The standard syntax for JDBC URLs is shown here. It has three parts, which
are separated by colons.
>
> jdbc:\<subprotocol\>:\<subname\>
And maybe use a `flightsql://` for grpc and `flightsql:unix://`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
