fornwall commented on PR #4506: URL: https://github.com/apache/arrow-adbc/pull/4506#issuecomment-4957426184
> Sorry - while we can do this, I didn't necessarily want to 👍 Absolutely. Let me know if you think it makes sense to continue this PR for now, or if we should close it for now. > At the very least, since this will (IIRC) raise the manylinux target on wheels, I would want to announce in the next release that this is coming, and only after make the change. It doesn't seem to raise the manylinux target - that will only happen by specific code causing references to new symbols (such as `std::format` on `chrono` types). There is an existing test [here](https://github.com/apache/arrow-adbc/blob/main/ci/scripts/python_wheel_unix_build.sh#L50-L69), so that does not slip by silently. > Also, like, instead of upgrading {fmt} I'd rather get rid of it in favor of std::format (etc.) Let me know if you want to proceed with this C++20 update, and I can have a look at it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
