lidavidm commented on PR #4506: URL: https://github.com/apache/arrow-adbc/pull/4506#issuecomment-4957468674
> It doesn't seem to raise the manylinux target - that will only happen by specific code causing references to new symbols (such as `std::format` on `chrono` types). There is an existing test [here](https://github.com/apache/arrow-adbc/blob/main/ci/scripts/python_wheel_unix_build.sh#L50-L69), so that does not slip by silently. IIRC, the C++ compilers available on the manylinux2014 build image only have minimal C++20 support - so while an initial compile may work, there would be no point just raising the standard if we can't actually use it. And so I'd rather just hold off in that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
