dmitry-chirkov-dremio commented on code in PR #50441:
URL: https://github.com/apache/arrow/pull/50441#discussion_r3572093298
##########
cpp/src/gandiva/precompiled/time_test.cc:
##########
@@ -59,6 +63,24 @@ TEST(TestTime, TestCastDate) {
EXPECT_EQ(castDATE_date32(1), 86400000);
}
+TEST(TestTime, TestCastDateInvalidUnterminated) {
Review Comment:
It appears that time and timestamp are going through the same code path. Is
this so?
If yes, would there be value in adding two more tests for those data types?
p.s. rest of PR looks good to me just need an evaluation of value of
additional tests as helper isn't really data type specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
