Arawoof06 commented on code in PR #50441:
URL: https://github.com/apache/arrow/pull/50441#discussion_r3576136200
##########
cpp/src/gandiva/precompiled/time_test.cc:
##########
@@ -59,6 +63,24 @@ TEST(TestTime, TestCastDate) {
EXPECT_EQ(castDATE_date32(1), 86400000);
}
+TEST(TestTime, TestCastDateInvalidUnterminated) {
Review Comment:
Yeah, both castTIMESTAMP_utf8 and castTIME_utf8 hit the same
set_error_for_date helper, so the fix already covers them. Added a test for
each anyway (2000-01-01 24:00:00 for timestamp, 24H00H00 for time) so the
over-read path is exercised from all three entry points with an unterminated
buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
