peterxcli opened a new pull request, #10336: URL: https://github.com/apache/arrow-rs/pull/10336
# Which issue does this PR close? Part of https://github.com/apache/arrow-rs/issues/9030. # Rationale for this change As part of updating Datafusion to better support date / time math operations (https://github.com/apache/datafusion/issues/19022 among others) it was uncovered that `arrow-rs` does not support interval * number ops that should be valid. For example: interval '1 second' * 900 → 00:15:00 interval '1 day' * 21 → 21 days this pr only include the interval multiply integer support because div and floating is too complex in case of https://github.com/apache/arrow-rs/pull/6906#discussion_r1894338923 # What changes are included in this PR? Allow: - (Int64, Interval(YearMonth)) - (Int64, Interval(DayTime)) - (Int64, Interval(MonthDayNano) and their swap to multiple. # Are these changes tested? # Are there any user-facing changes? yes, arithmetic_op now accept 1. (Interval(YearMonth), Int64) 2. (Interval(DayTime), Int64) 3. (Interval(MonthDayNano), Int64) 4. (Int64, Interval(YearMonth)) 5. (Int64, Interval(DayTime)) 6. (Int64, Interval(MonthDayNano)) as its (lhs, rhs) pair type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
