Rich-T-kid commented on PR #10317: URL: https://github.com/apache/arrow-rs/pull/10317#issuecomment-4970510257
> It doesn't duplicate the logic, i.e, the fallible versions are just try_<method>().unwrap() which means we don't need to adjust it in two places This makes sense, this is a much cleaner pattern and it makes migration later down the line. >It uses an opaque struct rather than an enum, which means we are more free to adjust implementation without changing internals, making it a breaking api change. I can see how this may be a worry but I think the number of ways these functions can fail is very small. I think an enum is more applicable in this case. happy to hear other thoughts on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
