fallintoplace opened a new pull request, #945: URL: https://github.com/apache/arrow-go/pull/945
### Rationale for this change The AES decryption helpers trusted length prefixes and nonce/tag sizes, allocated directly from the declared length, and panicked on framing or authentication failures. Malformed encrypted input should be reported through the existing reader error paths. ### What changes are included in this PR? - Validate length prefixes, nonce/tag minimums, and complete frames before slicing. - Bound streaming ciphertext allocation with a caller-provided maximum. - Return GCM authentication and framing errors from the decryption interface. - Propagate decryption failures through file metadata, page data, page headers, bloom filters, and page indexes. - Preserve incremental encrypted page-header reads by waiting for a complete frame before decryption. ### Are these changes tested? Yes. Unit tests cover missing/truncated frames, undersized payloads, oversized declarations, trailing data, and invalid tags. The encryption, metadata, file-reader, and fixture-backed encryption suites pass. ### Are there any user-facing changes? Malformed encrypted Parquet data now returns an error instead of panicking or attempting an unbounded allocation. The changed decryption interface is under an internal package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
