Jefffrey commented on code in PR #10325:
URL: https://github.com/apache/arrow-rs/pull/10325#discussion_r3586705007
##########
arrow-select/src/take.rs:
##########
@@ -2915,4 +2926,74 @@ mod tests {
assert_eq!(run_result.run_ends().len(), 0);
assert_eq!(run_result.values().len(), 0);
}
+
+ #[test]
+ fn test_take_run_end_encoded_merges_identical_runs() {
+ // https://github.com/apache/arrow-rs/issues/7710
+ // Indices [0,1,4,5] select from [1,1,0,0,1,1] — the 0s are skipped,
+ // so the output should be a single run of 1s, not two.
+ let mut builder = PrimitiveRunBuilder::<Int32Type, Int32Type>::new();
+ builder.extend([1, 1, 0, 0, 1, 1].into_iter().map(Some));
+ let ree = builder.finish();
+
+ let indexes = Int32Array::from_iter_values(vec![0, 1, 4, 5]);
+ let result = take(&ree, &indexes, None).unwrap();
+ let result = result
+ .as_run::<Int32Type>()
+ .downcast::<Int32Array>()
+ .unwrap();
+
+ let actual = result.into_iter().flatten().collect::<Vec<_>>();
+ assert_eq!(actual, vec![1, 1, 1, 1]);
Review Comment:
should we be verifying the internals of runarray here that it indeed holds a
single run physically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
