ianmcook commented on code in PR #4525: URL: https://github.com/apache/arrow-adbc/pull/4525#discussion_r3606399648
########## docs/source/javascript/quickstart.rst: ########## @@ -36,13 +35,36 @@ Installation .. note:: - Node.js 22+, Deno 2.0+, or Bun 1.1+ are required. + Node.js 22+, Deno 2.0+, or Bun 1.1+ are required. This does not work in the + browser: the driver manager loads driver shared libraries from the + filesystem, which browsers cannot do. -To use any driver with the JavaScript driver manager, you'll need install the -appropriate driver shared library for your platform separately and pass the -absolute path to the driver manager. +To use any driver with the JavaScript driver manager, you need the driver's +shared library on your machine. -Some examples for the SQLite driver are provided below for convenience: +The easiest way to get it is with `dbc <https://docs.columnar.tech/dbc/>`__, +which installs prebuilt driver binaries from Columnar's `ADBC driver registry +<https://dbc-cdn.columnar.tech>`__: Review Comment: Done in 4d252ff7b4d70d1dbc4dce4121d3c342467395ba ########## docs/source/python/quickstart.rst: ########## @@ -19,14 +19,21 @@ Quickstart ========== -Here we'll briefly tour basic features of ADBC with the SQLite driver. +Here we'll briefly tour basic features of ADBC with Python using the SQLite driver. Installation ============ .. code-block:: shell - pip install adbc_driver_manager adbc_driver_sqlite pyarrow + pip install adbc_driver_manager pyarrow + +Installing Drivers +------------------ + +See :ref:`driver-table-install` for instructions on installing ADBC drivers for +the database you want to connect to. For the example below, you could install +`dbc <https://docs.columnar.tech/dbc>`__ and run ``dbc install sqlite``. Review Comment: Done in 4d252ff7b4d70d1dbc4dce4121d3c342467395ba -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
