AlenkaF commented on code in PR #45998:
URL: https://github.com/apache/arrow/pull/45998#discussion_r3614798484
##########
cpp/src/arrow/filesystem/hdfs.cc:
##########
@@ -39,28 +38,114 @@ using util::Uri;
namespace fs {
+#define CHECK_FAILURE(RETURN_VALUE, WHAT) \
+ do { \
+ if (RETURN_VALUE == -1) { \
+ return IOErrorFromErrno(errno, "HDFS ", WHAT, " failed"); \
+ } \
+ } while (0)
+
+static constexpr int kDefaultHdfsBufferSize = 1 << 16;
Review Comment:
Oh, thank you @raulcd for this comment! I had to spend some time thinking
about why I would left `cpp/src/arrow/io/hdfs.cc` with such a small change, as
it doesn't make sense. I came to the conclusion this is most probably an
unfortunate leftover from a, quite painful, merge conflict I had here 3 weeks
ago. I wasn't sure if I missed something there. So I guess I did.
I will remove the file, look for any other possible issues with Claude, and
check if the CI passes.
Thanks again!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
