C-Loftus commented on code in PR #969:
URL: https://github.com/apache/arrow-go/pull/969#discussion_r3622225314
##########
parquet/pqarrow/schema.go:
##########
@@ -531,6 +538,9 @@ func arrowFromByteArray(logical schema.LogicalType)
(arrow.DataType, error) {
return arrow.BinaryTypes.String, nil
case schema.DecimalLogicalType:
return arrowDecimal(logtype), nil
+ case schema.GeometryLogicalType,
+ schema.GeographyLogicalType:
+ return arrowExtensionFromParquetLogicalType(logical,
arrow.BinaryTypes.Binary)
Review Comment:
Is there a way I can allow it to efficiently check either `Binary` or
`LargeBinary` to allow decoding either 32 bit or 64 bit wkb values? I think at
the moment this will only handle reading 32 bit. I can also just add a second
case here in case the first `arrowExtensionFromParquetLogicalType(logical,
arrow.BinaryTypes.Binary)` call returns no mapping? (i.e. try again with
`arrowExtensionFromParquetLogicalType(logical, arrow.BinaryTypes.LargeBinary)`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
