zeroshade commented on code in PR #969:
URL: https://github.com/apache/arrow-go/pull/969#discussion_r3624286319
##########
parquet/pqarrow/schema.go:
##########
@@ -531,6 +538,9 @@ func arrowFromByteArray(logical schema.LogicalType)
(arrow.DataType, error) {
return arrow.BinaryTypes.String, nil
case schema.DecimalLogicalType:
return arrowDecimal(logtype), nil
+ case schema.GeometryLogicalType,
+ schema.GeographyLogicalType:
+ return arrowExtensionFromParquetLogicalType(logical,
arrow.BinaryTypes.Binary)
Review Comment:
I don't think there's a way for it to tell from the logical type whether or
not it should use `Binary` or `LargeBinary` (or `BinaryView`). The difference
is solely whether or not there happens to be more than 2GB worth of data in a
single record batch. So even if you were to add a second case here, it's likely
not a useful thing (all extension types that support Binary should also support
LargeBinary and vice versa).
The better solution here, like the usage of `String` instead of
`LargeString` above, is to ensure that we properly promote to LargeBinary if
necessary, but that can be a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
