zeroshade commented on code in PR #970:
URL: https://github.com/apache/arrow-go/pull/970#discussion_r3624240555
##########
arrow/compare.go:
##########
@@ -100,8 +100,6 @@ func TypeEqual(left, right DataType, opts
...TypeEqualOption) bool {
switch {
case len(l.fields) != len(r.fields):
return false
- case !reflect.DeepEqual(l.index, r.index):
- return false
}
Review Comment:
should we just get rid of the switch then? and just make this a simple `if
len(l.fields) != len(r.fields) { return false }` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
