Copilot commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3637371027
##########
r/inst/build_arrow_static.sh:
##########
@@ -107,8 +107,9 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
-DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
-DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
- -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
-Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
+ -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
+ -Dsimdjson_SOURCE=${simdjson_SOURCE:-} \
Review Comment:
`build_arrow_static.sh` now always passes
`-Dsimdjson_SOURCE=${simdjson_SOURCE:-}`. When `simdjson_SOURCE` is unset and
`ARROW_DEPENDENCY_SOURCE` defaults to `AUTO` in this script, CMake will fall
back to `simdjson_SOURCE=AUTO` and can still pick up an incompatible system
simdjson (the failure this PR is trying to avoid) when the script is invoked
directly. Defaulting this to `BUNDLED` here makes the behavior consistent and
reduces reliance on callers to set `simdjson_SOURCE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
