Reranko05 commented on code in PR #50587: URL: https://github.com/apache/arrow/pull/50587#discussion_r3644086799
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -410,6 +410,13 @@ if(ARROW_AZURE) set(ARROW_WITH_AZURE_SDK ON) endif() +if(ARROW_JSON + AND CMAKE_OSX_SYSROOT + AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$") + message(STATUS "Disabling ARROW_JSON for macOS SDK 11.3") + set(ARROW_JSON OFF) Review Comment: I agree this approach is more appropriate if it works. However, I checked the latest Crossbow job and the `Disabling ARROW_JSON for macOS SDK 11.3` status message never appears, which suggests the if condition isn't being entered at all. So firstly we need to understand why that condition isn't matching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
