rok commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3644186166
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,13 @@ if(ARROW_AZURE)
set(ARROW_WITH_AZURE_SDK ON)
endif()
+if(ARROW_JSON
+ AND CMAKE_OSX_SYSROOT
+ AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+ message(STATUS "Disabling ARROW_JSON for macOS SDK 11.3")
+ set(ARROW_JSON OFF)
Review Comment:
I don't think CMAKE output will be printed as is. Perhaps enable ARROW_R_DEV
flag to make sure your ("Disabling ARROW_JSON for macOS SDK 11.3") message is
printed:
```diff
diff --git a/dev/tasks/r/github.macos.cran.yml
b/dev/tasks/r/github.macos.cran.yml
--- a/dev/tasks/r/github.macos.cran.yml
+++ b/dev/tasks/r/github.macos.cran.yml
@@ -80,6 +80,7 @@ jobs:
- name: Install (cran-release)
if: matrix.config == 'cran-release'
env:
+ ARROW_R_DEV: true
_R_CHECK_CRAN_INCOMING_: false
SDKROOT: '/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk'
NOT_CRAN: false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
