Dandandan commented on pull request #342:
URL: https://github.com/apache/arrow-datafusion/pull/342#issuecomment-841685880


   > @Dandandan I hope I understood the requested change correctly. Was not 
familiar with bitvec before, but I used the docs and I think I implemented it 
correctly
   
   Yes, this is awesome, exactly what I meant! Impressive how little is changed.
   
   I will do some benchmarking tonight or tomorrow to see if it's changing 
anything (but I believe this part is not the most performance sensitive anyway).
   
   @alamb @andygrove @jorgecarleitao 
   What do you think about adding bitvec as dependency? It might be useful 
later for other datastructures / algorithms too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to