Dandandan commented on pull request #342:
URL: https://github.com/apache/arrow-datafusion/pull/342#issuecomment-841780393


   > Thanks a lot @boaz-codota !
   > 
   > Is there any performance difference? imo It would be good to measure 
before adding a dependency.
   > 
   > Note that arrow also has an `BooleanBufferBuilder` or something that can 
create a bitmap.
   
   The idea is here is not performance per se, but memory savings. As this is 
an in-memory join, any saved memory is welcome, as it will increase the chance 
a given join will fit in memory.
   
   Using a boolean array buffer builder makes sense to me to avoid the 
dependency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to