ennuite commented on code in PR #732:
URL: https://github.com/apache/arrow-go/pull/732#discussion_r3670708880
##########
arrow/flight/flightsql/client_test.go:
##########
@@ -423,6 +423,123 @@ func (s *FlightSqlClientSuite)
TestPreparedStatementExecute() {
s.Equal(&emptyFlightInfo, info)
}
+func (s *FlightSqlClientSuite) TestPreparedStatementExecuteWithIsUpdateFalse()
{
Review Comment:
I addressed this in
https://github.com/apache/arrow-go/pull/732/changes/a324e276df3cc4727fe6d9befaca6aef76d0b838
I do not think it makes sense to have the check in `val`: it being `False`
seems like an implementation detail, and not a part of the contract of the
`IsUpdate() `method. Let me know if you disagree: I can change it to look
exactly like your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
