ennuite commented on code in PR #732:
URL: https://github.com/apache/arrow-go/pull/732#discussion_r3675903358
##########
arrow/flight/flightsql/server_test.go:
##########
@@ -133,6 +133,74 @@ func (*testServer) DoGetStatement(ctx context.Context,
ticket flightsql.Statemen
return
}
+func (*testServer) CreatePreparedStatement(ctx context.Context, req
flightsql.ActionCreatePreparedStatementRequest) (result
flightsql.ActionCreatePreparedStatementResult, err error) {
Review Comment:
Addressed this in
https://github.com/apache/arrow-go/pull/732/changes/221f7d6192200dda548ad043bb091e14cf88d754
I purposefully do not execute the query: since the hint is not set, it is up
to the client to decide whether to execute with `DoGet` or `DoPut`. I do not
want the test to misguide someone to think that one way is preferred.
The same nuance about checking `val` when `ok` is `False` is also present in
this test (see
https://github.com/apache/arrow-go/pull/732#discussion_r3670708880)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
