pitrou commented on code in PR #50725:
URL: https://github.com/apache/arrow/pull/50725#discussion_r3684577881
##########
cpp/src/arrow/json/json_writer_internal.cc:
##########
@@ -96,6 +98,117 @@ void JsonWriter::Double(double value) {
needs_comma_ = true;
}
+Status JsonWriter::WriteValue(sj::value value) {
+ sj::json_type type;
+ if (auto error = value.type().get(type); error != simdjson::SUCCESS) {
+ return Status::Invalid(simdjson::error_message(error));
+ }
+
+ switch (type) {
Review Comment:
> Good point. We caaddress this as part of the shared simdjson helper
refactoring.
Just FTR, it's ok to refactor as a separate PR, but it might be simpler for
everyone to do it in this very PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
