raulcd commented on code in PR #50741:
URL: https://github.com/apache/arrow/pull/50741#discussion_r3688852803


##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -61,6 +61,12 @@ if(ARROW_WITH_LZ4)
   endif()
 endif()
 
+if(ARROW_WITH_SIMDJSON)
+  if(simdjson_SOURCE STREQUAL "SYSTEM")
+    list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS simdjson::simdjson)
+  endif()
+endif()

Review Comment:
   The best place would be to try and add something more automatic into 
resolve_dependency when using `SYSTEM` but target names are quite varied and 
sometimes not yet known when resolving the dependency, example 
`ARROW_ZSTD_LIBZSTD`. I'll open an issue maybe we can investigate further or 
try some things.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to