Copilot commented on code in PR #50786:
URL: https://github.com/apache/arrow/pull/50786#discussion_r3705430334
##########
r/R/type.R:
##########
@@ -88,12 +88,6 @@ FLOAT_TYPES <- c("float16", "float32", "float64",
"halffloat", "float", "double"
#' @export
infer_type <- function(x, ...) UseMethod("infer_type")
Review Comment:
The roxygen text still uses a markdown link to [type()], but the type()
alias has been deleted. This will regenerate a man page containing a broken
link/reference.
##########
r/man/infer_type.Rd:
##########
@@ -2,12 +2,9 @@
% Please edit documentation in R/type.R
\name{infer_type}
\alias{infer_type}
-\alias{type}
\title{Infer the arrow Array type from an R object}
\usage{
infer_type(x, ...)
-
-type(x)
}
Review Comment:
The \description section still links to \link[=type]{type()}, but type() has
been removed (no longer exported/aliased). This will create a broken Rd link.
##########
r/R/dplyr-funcs-doc.R:
##########
@@ -100,24 +100,24 @@
#'
#' ## base
#'
-#' * [`!`][!()]
-#' * [`!=`][!=()]
-#' * [`%%`][%%()]
-#' * [`%/%`][%/%()]
-#' * [`%in%`][%in%()]
-#' * [`&`][&()]
-#' * [`*`][*()]
-#' * [`+`][+()]
-#' * [`-`][-()]
-#' * [`/`][/()]
-#' * [`<`][<()]
-#' * [`<=`][<=()]
-#' * [`==`][==()]
-#' * [`>`][>()]
-#' * [`>=`][>=()]
+#' * [`!`][base::!()]
+#' * [`!=`][base::!=()]
+#' * [`%%`][base::%%()]
+#' * [`%/%`][base::%/%()]
+#' * [`%in%`][base::%in%()]
Review Comment:
This source doc block says "Arrow's 281 compute functions" (line 87), but
the generated man page (r/man/acero.Rd) now says 254. This inconsistency will
come back the next time docs are regenerated unless the source is updated to
match.
##########
r/NAMESPACE:
##########
@@ -279,7 +279,6 @@ export(Type)
export(UnionDataset)
export(all_of)
export(arrow_array)
-export(arrow_available)
export(arrow_info)
export(arrow_table)
Review Comment:
PR description says "No" user-facing changes, but this PR removes exported
functions (e.g. arrow_available() and type()) from the public R API. Please
update the PR description (and/or NEWS) to reflect this API change.
##########
r/man/FileSystem.Rd:
##########
@@ -193,8 +193,5 @@ to running any code that interacts with S3. Possible values
include 'FATAL'
On \code{AzureFileSystem}, passing no arguments for authentication uses the
\code{AzureDefaultCredential} for authentication, so that several
authentication
types are tried until one succeeds.
-
-\code{AzureFileSystem} is not presently supported on Windows due to upstream
compatibility
-issues between the Azure C++ SDK and the MinGW toolchain.
}
Review Comment:
This removes the note that AzureFileSystem is unsupported on Windows, but
other project docs still state Azure is not available on Windows builds (e.g.
r/vignettes/fs.Rmd:40 and r/vignettes/developers/binary_features.Rmd:51-53,
98). Either the other docs need updating, or this note should remain here to
avoid misleading users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
