emilk opened a new pull request, #10533: URL: https://github.com/apache/arrow-rs/pull/10533
# Which issue does this PR close? - Related to #10458, which notes that `clippy::allow_attributes` should eventually be enabled *at the workspace level* — this PR adds that infrastructure. # Rationale for this change Lint configuration is currently repeated per crate in `lib.rs`. A `[workspace.lints]` table lets us configure lints once, for every crate, and makes rolling out new lints a one-line change. # What changes are included in this PR? Modeled on [egui's `Cargo.toml`](https://github.com/emilk/egui/blob/main/Cargo.toml). Three commits: 1. `[workspace.lints]` in the root `Cargo.toml` + `[lints] workspace = true` in all 27 members, starting with a deliberately small set of `allow`-by-default clippy lints that have **zero** violations today. 2. `[workspace.lints.rust]`: the `rust_2018_idioms`, `future_incompatible` and `nonstandard_style` groups. Three `rust_2018_idioms` members have 60–1200 violations, so they are explicitly allowed with a TODO. 3. `[workspace.lints.rustdoc]`: `rustdoc::all`, plus fixes for its 20 violations — 8 doc-comment typos, 8 missing crate-level docs, and 4 doc examples that were silently never run (details in the commit message). Note that `arrow-pyarrow-testing` and `arrow-pyarrow-integration-testing` are excluded from the workspace and so cannot inherit these lints. # Are these changes tested? Yes, by existing CI: `cargo clippy --workspace --all-targets --all-features -- -D warnings` and the docs job (`RUSTDOCFLAGS=-Dwarnings`) both pass. Two previously-dead doc examples now actually compile and run. # Are there any user-facing changes? `parquet_variant_compute::VariantArrayIter` is now exported — it was already returned by the public `VariantArray::iter`, but was not nameable. No other API changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
