alamb commented on code in PR #10533:
URL: https://github.com/apache/arrow-rs/pull/10533#discussion_r3714507063
##########
arrow-arith/Cargo.toml:
##########
@@ -49,3 +49,6 @@ criterion = { workspace = true }
[[bench]]
name = "decimal_arithmetic"
harness = false
+
+[lints]
Review Comment:
❤️
##########
arrow-select/src/filter.rs:
##########
@@ -2366,7 +2366,7 @@ mod tests {
}
#[test]
- #[should_panic]
+ #[should_panic(expected = "values.len() >= predicate.filter.len()")]
Review Comment:
this is a nice lint to insist on error messages
##########
parquet/src/errors.rs:
##########
@@ -198,3 +202,25 @@ impl From<ParquetError> for ArrowError {
Self::ParquetError(format!("{p}"))
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ /// The single-argument arms of the error macros must format their
argument, so that
+ /// inline format arguments are not silently emitted as literal text.
+ #[test]
+ fn error_macros_format_inline_args() {
+ let expected = 1;
+ let actual = 2;
+ assert_eq!(
Review Comment:
this seems like a nice fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
