HuaHuaY commented on code in PR #50807:
URL: https://github.com/apache/arrow/pull/50807#discussion_r3719384015
##########
cpp/src/parquet/statistics.h:
##########
@@ -134,11 +134,13 @@ class PARQUET_EXPORT EncodedStatistics {
int64_t null_count = 0;
int64_t distinct_count = 0;
+ int64_t nan_count = 0;
Review Comment:
I choose to follow the style of `null_count` and `distinct_count`. I think
there will be many diff changes to modifying them together. If we decide to do
this, I recommend putting the changes in a separate PR. However, since it
involves changes to a public API, we had better to put the two PRs in the same
Arrow release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
